-
Notifications
You must be signed in to change notification settings - Fork 219
Optimisation plugin for usage with Flutter module. #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EgorLogachev
wants to merge
16
commits into
LinusU:master
Choose a base branch
from
Ingenio:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has been removed from plugin, process of receiving of callback uri has been refactored, CallbackActivity has been removed as redundant
…esult_on_android Returning result for android has been re-worked, cleanUpDanglingCalls…
…nking Feature/app delegate controller linking
… Chrome installed
…to_flutter_3.0 KAA-1037: fixed override of onNewIntent by making Intent non-nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @LinusU . Thank you for your flutter_web_auth plugin. It helped us with our OAuth solution and saved our time. In our case we have 3 mobile apps on Native Android, iOS, and Flutter with the same functionality of authorization, so we've decided to implement the Flutter module and integrate it to the native side. We've faced some problems, so we have decided to optimize flutter_web_auth for Flutter modules. I suggest it can be useful for you and developers that use your solution.
Changes:
BREAKING CHANGES:
As I understood you were faced with the problem of handling browser results on Android, so you have added the cleanUpDanglingCalls feature. This feature has been re-worked and replaced from Flutter public interface to the Android native side.
We had a problem on the iOS side with obtaining FlutterViewController because in our case FlutterViewController was presented as a modal controller, so this line of code
UIApplication.shared.delegate?.window??.rootViewController as? FlutterViewController
didn't work for us. To fix that we have addedFlutterPresentationContextProviding
protocol, and each developer can implement it for AppDelegate and implement logic on how to obtain FlutterViewContorller.